search

apache / incubator-graphar

An open source, standard data file format for graph data storage and retrieval.
https://graphar.apache.org/
Apache License 2.0
217 stars 46 forks source link

Multi-label filtering #607

Open Elssky opened 1 month ago

Elssky commented 1 month ago

Reason for this PR

The support of multi-label function is very important for users. This PR implements compatibility with multi-label data and provides label filtering function (to facilitate users to quickly find specific label vertices)

What changes are included in this PR?

It mainly implements three major functions:

  1. Read multi-label data and build graphs for storage.
  2. Allow users to specify one or more labels to filter vertices.
  3. Access label information of a single vertex.

    Are these changes tested?

    yes, and it has been modified before, see https://github.com/apache/incubator-graphar/pull/605

acezen commented 1 week ago

Hi, @Elssky, it's better to remove the WIP to trigger the CI.

Elssky commented 1 week ago

Hi, @Elssky, thanks for the contribution, I have roughly review the PR and leaved some comments. To make the PR more clear and elegant， I highly recommend that

  • Add document or update the document if you add new API or break down the current API
  • Don't make this feature as a HUGE PR if you can split the feature into some sub-feature. That would make reviewing easier and help to back track.

yes, I seperate this PR to https://github.com/apache/incubator-graphar/pull/634 and https://github.com/apache/incubator-graphar/pull/635/commits/8813288622876441693219053ae6f9f324bffddf