search

apache / incubator-heron

Apache Heron (Incubating) is a realtime, distributed, fault-tolerant stream processing engine from Twitter
https://heron.apache.org/
Apache License 2.0
3.64k stars 597 forks source link

Helm chart cleanup #3758

Closed nicknezis closed 2 years ago

nicknezis commented 2 years ago
  1. Updated Helm to 3.7.2.
  2. Added LICENSE, NOTICE and DISCLAIMER files to Helm chart
  3. Updated the Helm chart.yaml apiVersion to v2 (Helm 3.x)

Helm v2 is necessary to make the Helm chart discoverable in the apache.jfrog.org Helm repo.

I tried to find a way to instruct Helm to leave the commented LICENSE header in the Chart.yaml, but it seems the Chart.yaml is always processed to a final form with no comments.

surahman commented 2 years ago

For posterity:

I tried to find a way to instruct Helm to leave the commented LICENSE header in the Chart.yaml, but it seems the Chart.yaml is always processed to a final form with no comments.

As per the conversation Nick initiated on dev@h.a.o on this issue, it is acceptable for a file that is generated or processed to not contain the ASF header. I also have been unable to find a way to work around the pre-processing performed server/client-side.