Renamed variable but not updating the js

apache / incubator-heron

Apache Heron (Incubating) is a realtime, distributed, fault-tolerant stream processing engine from Twitter

https://heron.apache.org/

Apache License 2.0

3.65k stars 598 forks source link

Renamed variable but not updating the js #3801

Closed windhamwong closed 1 year ago

windhamwong commented 2 years ago

https://github.com/apache/incubator-heron/blob/9cfc5c4785ba0c14d26dfbbf0fe1d6b477dd38a5/heron/tools/ui/resources/static/js/physical-plan.js#L55

Looks like the code containers[worker.stmgrId] is invalid because the stmgr ID has been renamed to worker.stmgr_id.

I am using /pull/3779 based on master, but the PR has no change to the code.

windhamwong commented 2 years ago

Confirmed working if changing stmgrId to stmgr_id. See if anyone has the same issue, i have created PR

nicknezis commented 2 years ago

This is currently being worked in #3786 . Feel free to submit any pull requests to that branch as we resolve the issues. There were many more broken aspects when we updated the code to support the newer Python versions.

nicknezis commented 1 year ago

I believe this is now working with #3786 merged. Please re-open if it is still an issue.