search

apache / incubator-heron

Apache Heron (Incubating) is a realtime, distributed, fault-tolerant stream processing engine from Twitter
https://heron.apache.org/
Apache License 2.0
3.65k stars 597 forks source link

travis ci fails to catch the serialVersionUID missing problem #719

Open nlu90 opened 8 years ago

nlu90 commented 8 years ago

When we are building the binary for a new release with docker/build-artifacts.sh darwin 0.13.7 ~/darwin, we encountered the following errors:

INFO: From Building heron/storm/src/java/libstorm-compatibility-java.jar (201 files):
heron/storm/src/java/backtype/storm/testing/TestWordSpout.java:27: warning: [serial] serializable class TestWordSpout has no definition of serialVersionUID
public class TestWordSpout extends BaseRichSpout {
       ^
error: warnings found and -Werror specified
heron/storm/src/java/org/apache/storm/testing/TestWordSpout.java:26: warning: [serial] serializable class TestWordSpout has no definition of serialVersionUID
public class TestWordSpout extends BaseRichSpout {

Travis CI didn't catch this problem when the PR #711 is published. We need to understand why this happens and catch such errors before the pr is merged.

billonahill commented 8 years ago

Possibly related to #655

kramasamy commented 8 years ago

@nlu90 - this is fixed - can you close the issue?