codecov-commenter
commented
1 year ago Codecov Report
Merging #138 (507489e) into main (494e15e) will decrease coverage by
1.53%. The diff coverage is51.73%.
@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 39.07% 37.55% -1.53%
==========================================
Files 33 34 +1
Lines 4217 4385 +168
==========================================
- Hits 1648 1647 -1
- Misses 2317 2496 +179
+ Partials 252 242 -10 | Impacted Files | Coverage Δ | |
|---|---|---|
| server/cluster/cluster.go | 0.00% <0.00%> (ø) |
|
| server/cluster/table_manager.go | 0.00% <0.00%> (ø) |
|
| server/cluster/types.go | 0.00% <0.00%> (ø) |
|
| server/coordinator/factory.go | 0.00% <0.00%> (ø) |
|
| .../coordinator/procedure/create_table_common_util.go | 0.00% <0.00%> (-70.50%) |
:arrow_down: |
| server/coordinator/procedure/util.go | 0.00% <0.00%> (-38.89%) |
:arrow_down: |
| server/coordinator/scheduler.go | 0.00% <0.00%> (ø) |
|
| ...dml/createpartitiontable/create_partition_table.go | 39.11% <35.29%> (ø) |
|
| ...rdinator/procedure/dml/createtable/create_table.go | 46.23% <46.23%> (ø) |
|
| .../coordinator/procedure/dml/droptable/drop_table.go | 50.73% <50.73%> (ø) |
|
| ... and 10 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
chunshao90
jiacai2050
Which issue does this PR close?
Closes #
Rationale for this change
We have developed multiple Procedures to manage the state machine and retry process, but they are defined under the same
procedurepackage. In order to avoid constant conflicts, we have adopted unreasonable naming methods. Now do a refactoring and disassemble them. Divide into multiple packages, and adjust the naming of constants.What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Passing exists unit tests.