apache / incubator-horaedb-meta

Meta service of HoraeDB cluster.
https://horaedb.apache.org
Apache License 2.0
27 stars 15 forks source link

refactor: avoid frequent update of clusterVersion #166

Closed ZuLiangWang closed 1 year ago

ZuLiangWang commented 1 year ago

Which issue does this PR close?

Closes #

Rationale for this change

Check whether updates are required during node registration to avoid frequent updates of ClusterVersion and put pressure on ETCD.

What changes are included in this PR?

Are there any user-facing changes?

None.

How does this change test

Pass all unit tests.

codecov-commenter commented 1 year ago

Codecov Report

Merging #166 (d26ed88) into main (494e15e) will increase coverage by 0.78%. The diff coverage is 34.75%.

:exclamation: Current head d26ed88 differs from pull request most recent head fc60150. Consider uploading reports for the commit fc60150 to get more accurate results

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   39.07%   39.86%   +0.78%     
==========================================
  Files          33       34       +1     
  Lines        4217     4192      -25     
==========================================
+ Hits         1648     1671      +23     
+ Misses       2317     2296      -21     
+ Partials      252      225      -27     
Impacted Files Coverage Δ
server/cluster/metadata/cluster_metadata.go 0.00% <0.00%> (ø)
server/cluster/metadata/table_manager.go 0.00% <0.00%> (ø)
server/cluster/metadata/topology_manager.go 0.00% <0.00%> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/manager_impl.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <0.00%> (-38.89%) :arrow_down:
server/etcdutil/util.go 45.45% <0.00%> (-6.79%) :arrow_down:
server/coordinator/factory.go 4.51% <4.51%> (ø)
server/storage/types.go 63.54% <38.23%> (-7.01%) :arrow_down:
server/storage/storage_impl.go 62.30% <40.00%> (-1.21%) :arrow_down:
... and 14 more

... and 2 files with indirect coverage changes