apache / incubator-horaedb-meta

Meta service of HoraeDB cluster.
https://horaedb.apache.org
Apache License 2.0
27 stars 15 forks source link

fix: wrong shard id when drop non-exist table #230

Closed ShiKaiWi closed 1 year ago

ShiKaiWi commented 1 year ago

Which issue does this PR close?

Closes #

Rationale for this change

The shard is wrong when dropping a non-existent table.

What changes are included in this PR?

Throw an error when the table to drop is not found.

Are there any user-facing changes?

None.

How does this change test

Manually.

codecov[bot] commented 1 year ago

Codecov Report

Merging #230 (e0d4d74) into main (7f1354e) will increase coverage by 21.20%. Report is 33 commits behind head on main. The diff coverage is 62.85%.

@@             Coverage Diff             @@
##             main     #230       +/-   ##
===========================================
+ Coverage   39.66%   60.86%   +21.20%     
===========================================
  Files          34       43        +9     
  Lines        4213     5359     +1146     
===========================================
+ Hits         1671     3262     +1591     
+ Misses       2317     1690      -627     
- Partials      225      407      +182     
Files Changed Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) :arrow_down:
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) :arrow_down:
server/cluster/manager.go 38.96% <23.18%> (ø)
server/coordinator/factory.go 76.68% <30.76%> (+72.22%) :arrow_up:
.../operation/transferleader/batch_transfer_leader.go 33.80% <33.80%> (ø)
server/member/member.go 47.70% <47.82%> (-1.02%) :arrow_down:
... and 22 more

... and 1 file with indirect coverage changes