codecov[bot]
commented
1 year ago Codecov Report
Merging #268 (8f42732) into main (7f1354e) will increase coverage by
19.29%. Report is 65 commits behind head on main. The diff coverage is57.39%.
@@ Coverage Diff @@
## main #268 +/- ##
===========================================
+ Coverage 39.66% 58.96% +19.29%
===========================================
Files 34 42 +8
Lines 4213 5831 +1618
===========================================
+ Hits 1671 3438 +1767
+ Misses 2317 1979 -338
- Partials 225 414 +189 | Files | Coverage Δ | |
|---|---|---|
| pkg/coderr/code.go | 0.00% <ø> (ø) |
|
| server/coordinator/lock/entry_lock.go | 100.00% <ø> (ø) |
|
| server/coordinator/procedure/delay_queue.go | 91.30% <100.00%> (+0.25%) |
:arrow_up: |
| server/coordinator/procedure/util.go | 0.00% <ø> (ø) |
|
| server/etcdutil/get_leader.go | 0.00% <ø> (ø) |
|
| server/id/reusable_id_impl.go | 100.00% <100.00%> (ø) |
|
| server/member/lease.go | 78.62% <ø> (+1.46%) |
:arrow_up: |
| server/storage/meta.go | 0.00% <ø> (ø) |
|
| server/coordinator/factory.go | 76.25% <94.44%> (+71.79%) |
:arrow_up: |
| ...ver/coordinator/procedure/operation/split/split.go | 52.05% <75.00%> (+0.20%) |
:arrow_up: |
| ... and 29 more |
Rationale
For detail, see: https://github.com/CeresDB/ceresmeta/issues/263 In this pr, add the checksum repair logic of shard version.
Detailed Changes
MayCorrectShardVersioninRegisterNode, it will correct shard version when it is inconsistent in ceresmeta and ceresdb.Test Plan
I created some local shard version inconsistent scenarios to verify its repair ability.