search

apache / incubator-horaedb-meta

Meta service of HoraeDB cluster.
https://horaedb.apache.org
Apache License 2.0
27 stars 15 forks source link

Fmt check failed in go 1.19 #49

Closed Rachelint closed 2 years ago

Rachelint commented 2 years ago

Describe this problem

Make build failed due to fmt check in go 1.19.

Steps to reproduce

Expected behavior

Build success.

Additional Information

ShiKaiWi commented 2 years ago

I figure it out that it is an enhancement for gofmt introduced by go1.19 that causes the make check failed.:

Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.

ShiKaiWi commented 2 years ago

I will fix these comments, and upgrade to go1.19.