apache / incubator-hugegraph-commons

(Archived Warning)Please visit "apache/hugegraph" repo instead
https://github.com/apache/hugegraph/tree/master/hugegraph-commons
Apache License 2.0
29 stars 45 forks source link

fix: Assert.assertThrows() should check result of exceptionConsumer #135

Closed javeme closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5ad55fb) 93.15% compared to head (68b359e) 93.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #135 +/- ## ========================================= Coverage 93.15% 93.15% Complexity 65 65 ========================================= Files 9 9 Lines 263 263 Branches 22 22 ========================================= Hits 245 245 Misses 8 8 Partials 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

javeme commented 9 months ago

+ @zhenyuT

zhenyuT commented 9 months ago

Seems there's no need to use CompletableFuture in assertThrows method?