apache / incubator-hugegraph-commons

(Archived Warning)Please visit "apache/hugegraph" repo instead
https://github.com/apache/hugegraph/tree/master/hugegraph-commons
Apache License 2.0
29 stars 45 forks source link

refact(rpc): merge rpc module into commons #84

Closed imbajin closed 2 years ago

imbajin commented 2 years ago

for apache need, after this pr, we will:

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (6e2330d) into master (1d27452) will increase coverage by 4.09%. The diff coverage is 93.12%.

:exclamation: Current head 6e2330d differs from pull request most recent head ee08712. Consider uploading reports for the commit ee08712 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     89.03%   93.12%   +4.09%     
+ Complexity      943       65     -878     
============================================
  Files            63        9      -54     
  Lines          2744      262    -2482     
  Branches        399       22     -377     
============================================
- Hits           2443      244    -2199     
+ Misses          154        8     -146     
+ Partials        147       10     -137     
Impacted Files Coverage Δ
...n/java/com/baidu/hugegraph/version/RpcVersion.java 50.00% <50.00%> (ø)
...ava/com/baidu/hugegraph/rpc/RpcClientProvider.java 90.47% <90.47%> (ø)
...ava/com/baidu/hugegraph/rpc/RpcConsumerConfig.java 91.48% <91.48%> (ø)
.../java/com/baidu/hugegraph/rpc/RpcCommonConfig.java 91.66% <91.66%> (ø)
...c/main/java/com/baidu/hugegraph/rpc/RpcServer.java 92.06% <92.06%> (ø)
...in/java/com/baidu/hugegraph/config/RpcOptions.java 97.22% <97.22%> (ø)
...ain/java/com/baidu/hugegraph/rpc/RpcException.java 100.00% <100.00%> (ø)
...ava/com/baidu/hugegraph/rpc/RpcProviderConfig.java 100.00% <100.00%> (ø)
...m/baidu/hugegraph/rpc/RpcServiceConfig4Client.java 100.00% <100.00%> (ø)
...ava/com/baidu/hugegraph/concurrent/AtomicLock.java
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d27452...ee08712. Read the comment docs.

imbajin commented 2 years ago

after review & CI pass, separate this pr into 2