search

apache / incubator-hugegraph-computer

HugeGraph Computer - A distributed graph processing system for hugegraph (OLAP)
https://hugegraph.apache.org/docs/quickstart/hugegraph-computer/
Apache License 2.0
42 stars 41 forks source link

fix: superstep not take effect #237

Closed JackyYangPassion closed 1 year ago

JackyYangPassion commented 1 year ago

fix #236

codecov[bot] commented 1 year ago

Codecov Report

Merging #237 (9ddfe24) into master (cc5a7e7) will increase coverage by 0.05%. The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     85.83%   85.89%   +0.05%     
- Complexity     3232     3235       +3     
============================================
  Files           344      344              
  Lines         12072    12108      +36     
  Branches       1087     1090       +3     
============================================
+ Hits          10362    10400      +38     
- Misses         1185     1187       +2     
+ Partials        525      521       -4
Impacted Files Coverage Δ
...graph/computer/core/sender/MessageSendBuffers.java 86.36% <33.33%> (-8.38%) :arrow_down:
...graph/computer/core/sender/MessageSendManager.java 78.40% <100.00%> (ø)

... and 15 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

coderzc commented 1 year ago

CI failed:

Error: testRunAlgorithm(org.apache.hugegraph.computer.algorithm.community.lpa.LpaTest) Time elapsed: 9.086 s <<< ERROR! org.apache.hugegraph.exception.ServerException: Null key for a Map not allowed in JSON (use a converting NullKeySerializer?) (through reference chain: java.util.ArrayList[0]->java.util.HashMap["null"]) at org.apache.hugegraph.computer.algorithm.community.lpa.LpaTest.testRunAlgorithm(LpaTest.java:40) Caused by: org.apache.hugegraph.exception.ServerException$ServerCause: [org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException]

coderzc commented 1 year ago

@JackyYangPassion You can refer to TriangleCountTest to verify the algorithm results

JackyYangPassion commented 1 year ago

@JackyYangPassion You can refer to TriangleCountTest to verify the algorithm results

It is being tested and will help review after CI passes

JackyYangPassion commented 1 year ago

Unit test for https://github.com/apache/incubator-hugegraph-computer/issues/236 lpa expect result is 4 community