chore: correct incorrect comment

apache / incubator-hugegraph-computer

HugeGraph Computer - A distributed graph processing system for hugegraph (OLAP)

https://hugegraph.apache.org/docs/quickstart/hugegraph-computer/

Apache License 2.0

42 stars 41 forks source link

chore: correct incorrect comment #268

Closed diaohancai closed 11 months ago

diaohancai commented 11 months ago

Purpose of the PR

close #267

Main Changes

Correct incorrect comment.

Verifying these changes

[X] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[ ] Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

[X] Nope
[ ] Dependencies (add/update license info)
[ ] Modify configurations
[ ] The public API
[ ] Other affects (typed here)

Documentation Status

[ ] Doc - TODO
[ ] Doc - Done
[X] Doc - No Need

simon824 commented 11 months ago

By the way, hugegraph-computer ci was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity

codecov[bot] commented 11 months ago

Codecov Report

Merging #268 (ec06513) into master (fdb4621) will increase coverage by 0.05%. Report is 1 commits behind head on master. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
+ Coverage     85.83%   85.89%   +0.05%     
- Complexity     3235     3236       +1     
============================================
  Files           344      344              
  Lines         12115    12115              
  Branches       1092     1092              
============================================
+ Hits          10399    10406       +7     
+ Misses         1194     1187       -7     
  Partials        522      522

Files Changed	Coverage Δ
.../hugegraph/computer/core/common/ContainerInfo.java	`90.90% <ø> (ø)`

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Radeity commented 11 months ago

By the way, hugegraph-computer ci was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity

I've checked error logs and find that there's an unexpected state change, we expect to receive CANCELLED, but receive some states else. And may I ask why we have to sleep 1.5s after calling cancelJob because state may be changed to CANCELLED in this 1.5s and we will miss the state change in UT. cc @coderzc

https://github.com/apache/incubator-hugegraph-computer/blob/15fc9bb539902fb5e75cbc23bfb6be0c5904beed/computer-test/src/main/java/org/apache/hugegraph/computer/k8s/MiniKubeTest.java#L250-L257