Closed diaohancai closed 11 months ago
By the way, hugegraph-computer ci was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity
Merging #268 (ec06513) into master (fdb4621) will increase coverage by
0.05%
. Report is 1 commits behind head on master. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #268 +/- ##
============================================
+ Coverage 85.83% 85.89% +0.05%
- Complexity 3235 3236 +1
============================================
Files 344 344
Lines 12115 12115
Branches 1092 1092
============================================
+ Hits 10399 10406 +7
+ Misses 1194 1187 -7
Partials 522 522
Files Changed | Coverage Δ | |
---|---|---|
.../hugegraph/computer/core/common/ContainerInfo.java | 90.90% <ø> (ø) |
... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
By the way, hugegraph-computer ci was failed and it seems not to be caused by this PR. can u help to improve it when free? (i have rerun many times) @coderzc @Radeity
I've checked error logs and find that there's an unexpected state change, we expect to receive CANCELLED
, but receive some states else. And may I ask why we have to sleep 1.5s after calling cancelJob
because state may be changed to CANCELLED
in this 1.5s and we will miss the state change in UT. cc @coderzc
Purpose of the PR
Main Changes
Correct incorrect comment.
Verifying these changes
[ ] Need tests and can be verified as follows.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need