Closed Radeity closed 10 months ago
Hi @javeme , thanks for your comments, I will pay more attention at next time to write beautiful codes : )
Merging #269 (f3a2e5b) into master (15fc9bb) will decrease coverage by
0.66%
. Report is 1 commits behind head on master. The diff coverage is32.94%
.
@@ Coverage Diff @@
## master #269 +/- ##
============================================
- Coverage 85.81% 85.15% -0.66%
- Complexity 3233 3248 +15
============================================
Files 344 345 +1
Lines 12115 12283 +168
Branches 1092 1101 +9
============================================
+ Hits 10396 10460 +64
- Misses 1195 1297 +102
- Partials 524 526 +2
Files | Coverage Δ | |
---|---|---|
...ugegraph/computer/core/config/ComputerOptions.java | 98.94% <100.00%> (+0.05%) |
:arrow_up: |
...aph/computer/core/receiver/MessageRecvManager.java | 85.22% <100.00%> (+0.34%) |
:arrow_up: |
...h/computer/core/receiver/MessageRecvPartition.java | 97.59% <100.00%> (+0.02%) |
:arrow_up: |
.../computer/core/receiver/MessageRecvPartitions.java | 97.72% <100.00%> (+0.10%) |
:arrow_up: |
...receiver/message/ComputeMessageRecvPartitions.java | 100.00% <100.00%> (ø) |
|
.../hugegraph/computer/core/worker/WorkerService.java | 90.58% <100.00%> (+0.11%) |
:arrow_up: |
.../core/receiver/edge/EdgeMessageRecvPartitions.java | 66.66% <50.00%> (-33.34%) |
:arrow_down: |
...e/receiver/vertex/VertexMessageRecvPartitions.java | 66.66% <50.00%> (-33.34%) |
:arrow_down: |
...egraph/computer/core/input/WorkerInputManager.java | 90.56% <70.00%> (-5.18%) |
:arrow_down: |
...computer/core/network/buffer/FileRegionBuffer.java | 35.71% <0.00%> (-3.76%) |
:arrow_down: |
... and 1 more |
... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Purpose of the PR
Main Changes
SnapshotManager
to handle snapshot load and write.Verifying these changes
[x] Need tests and can be verified as follows.
For my LOCAL test, I deploy MinIO in standalone mode first. Then I test all possible scenarios when using this feature. And here's my testing results:
In later PR, I will support to deploy MinIO as internal storage. Then, I will add UT to replace manual test results.
Later PR (Task)
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need