Open Radeity opened 10 months ago
cc @coderzc
Feature Description (功能描述)
Now, we have
manager
container introduced by #259. Thus, we have to modify image building script.BTW, may I ask, currently, how to trigger new image building and uploading in HugeGraphComputer? It seems like
publish_images.yml
in.workflow
is deprecated?
due to lack some "GITHUB_TOKEN" permission here, so transfer to https://github.com/hugegraph/actions/blob/master/.github/workflows/publish_computer_image.yml
so as other similar CIs
Hi @imbajin , get it, thanks.
However, may I ask why we comment the cron schedule in publish_computer_image.yml
? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new image manager
) in this repo, either, and declare in our doc.
https://github.com/hugegraph/actions/blob/4eb9db3d644408df8f47558ecf151b510a1ffd24/.github/workflows/publish_computer_image.yml#L3-L5
Hi @imbajin , get it, thanks.
However, may I ask why we comment the cron schedule in
publish_computer_image.yml
? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new imagemanager
) in this repo, either, and declare in our doc. hugegraph/actions@4eb9db3
/.github/workflows/publish_computer_image.yml#L3-L5
Good catch & thanks for the reminder (Context: computer has not been updated for a period of time before, and it is unreasonable to keep updating the image on a regular crontab. We should use a hook mechanism that updates when there is a new commit)
@Radeity could u follow the PR (https://github.com/hugegraph/actions/pull/2) to update computer image with hook m* when free? (also divide it into 2 ci action for release/stable version)
If not free these days, could assign to @aroundabout & comment here
Feature Description (功能描述)
Now, we have
manager
container introduced by https://github.com/apache/incubator-hugegraph-computer/pull/259. Thus, we have to modify image building script.BTW, may I ask, currently, how to trigger new image building and uploading in HugeGraphComputer? It seems like
publish_images.yml
in.workflow
is deprecated?