chore(fix): add foreground process for hubble-1.0.0 image

apache / incubator-hugegraph-toolchain

HugeGraph toolchain - include a series useful graph modules

https://hugegraph.apache.org/

Apache License 2.0

82 stars 87 forks source link

chore(fix): add foreground process for hubble-1.0.0 image #565

Closed aroundabout closed 6 months ago

aroundabout commented 6 months ago

Purpose of the PR

in hubble-1.0.0, there is no foreground process, add the tail process

Main Changes

Verifying these changes

[ ] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[ ] Need tests and can be verified as follows:
- xxx

Does this PR potentially affect the following parts?

[ ] Nope
[ ] Dependencies (add/update license info)
[ ] Modify configurations
[ ] The public API
[ ] Other affects (typed here)

Documentation Status

[ ] Doc - TODO
[ ] Doc - Done
[ ] Doc - No Need

imbajin commented 6 months ago

Also fix the hubble CI error~

@dosu-bot what could u do for us?

devstein commented 6 months ago

Hey @imbajin Dosu can't be summoned on PRs at the moment

Out of curiosity, what was the behavior you were expecting? It's helpful to know for future features

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (docker-1.0.0@3f0a323). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## docker-1.0.0 #565 +/- ## =============================================== Coverage ? 62.55% Complexity ? 1866 =============================================== Files ? 260 Lines ? 9412 Branches ? 872 =============================================== Hits ? 5888 Misses ? 3142 Partials ? 382 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imbajin commented 6 months ago

Hey @imbajin Dosu can't be summoned on PRs at the moment

Out of curiosity, what was the behavior you were expecting? It's helpful to know for future features

Oh, I just test the function of it...

Because it also doesn't appear in issues (refer https://github.com/apache/incubator-hugegraph-toolchain/issues/563) So I wanted to test when & how it works... (BTW, I got your mail just now & have a good understanding of its context)