Closed SunnyBoy-WYH closed 8 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
1dd0580
) 66.32% compared to head (b0e1036
) 66.22%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...a/org/apache/hugegraph/api/profile/ProfileAPI.java | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@SunnyBoy-WYH Is this as expected?
> curl http://localhost:8080/ {"service":"hugegraph","version":"1.2.0","doc":"https://hugegraph.apache.org/docs/","api_doc":"https://hugegraph.apache.org/docs/clients/","swagger_ui":"http://{domain/ip}:{port}/swagger-ui/index.html#/","apis":["arthas","auth","cypher","filter","graph","gremlin","job","metrics","profile","raft","resources","schema","traversers","variables"]}
Is there a way to fill the ip and port in swagger_ui here?
Good suggestion, maybe it's better to get the uri info
from server status or use default IP:Port
for it?
@SunnyBoy-WYH Is this as expected?
> curl http://localhost:8080/ {"service":"hugegraph","version":"1.2.0","doc":"https://hugegraph.apache.org/docs/","api_doc":"https://hugegraph.apache.org/docs/clients/","swagger_ui":"http://{domain/ip}:{port}/swagger-ui/index.html#/","apis":["arthas","auth","cypher","filter","graph","gremlin","job","metrics","profile","raft","resources","schema","traversers","variables"]}
Is there a way to fill the ip and port in swagger_ui here?
Good suggestion, maybe it's better to get the
uri info
from server status or use defaultIP:Port
for it?
Yes, we can just use rest server url .
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need