Closed msgui closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1d4532c
) 66.23% compared to head (9ed3749
) 61.39%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fine, wonder to know all the files header are updated?
This PR solely updates the license header in hg-server/hg-api
.
fine, wonder to know all the files header are updated?
This PR solely updates the license header in
hg-server/hg-api
.
Get it, license header could update together (due to it is almost a completely repetitive task, just take a few samples for inspection and confirmation, no need to check them one by one)
@msgui I noticed that some configuration files, such as hugegraph-server/hugegraph-test/src/main/resources/hugegraph.properties
, do not have corresponding modified license headers. Is this expected?
@msgui I noticed that some configuration files, such as
hugegraph-server/hugegraph-test/src/main/resources/hugegraph.properties
, do not have corresponding modified license headers. Is this expected?
thanks for the reminder
this commit includes files of all formats for easy review.
👉:47e2fe24976efe092fd6f944444be00ba142cba5
Also, these extra blank lines here can be removed, it seems?
(compared to https://github.com/apache/incubator-hugegraph/wiki/HugeGraph-Code-Style-Guide)
PTAL~
- It seems reasonable to consider updating the license header for the entire repository, not just under
hugegraph-server
.- For the license headers only under
hugegraph-server
, there still seem to be some missed files. I have conducted a preliminary count (just a reminder):(expected: 791, actual: 783)
Thank you for the reminder. The license header format in the remaining files is already correct, so no further corrections are needed
@imbajin could also check again~
Additionally, I believe that performing the license header check in the current CI (licence-checker.yml) seems somewhat delayed. It might be worth considering moving it to the verify stage. This way, developers can discover related errors earlier during local builds.
@imbajin could also check again~
Additionally, I believe that performing the license header check in the current CI (licence-checker.yml) seems somewhat delayed. It might be worth considering moving it to the verify stage. This way, developers can discover related errors earlier during local builds.
Good suggestion, could mark it as a TODO (enhance our CI to check/validate style problems)
This tool hawkeye may help license header check and format?
- [x] keep the
dist/*/bin/*.properties
(user config files) clean (no need to add header here)
@imbajin Is it only for cleaning the license header in properties files in user configuration files here? I found that some other user configuration files have license headers.
Also, do properties files in the conf-raft*
directory need to have their license headers cleaned?
- [x] keep the
dist/*/bin/*.properties
(user config files) clean (no need to add header here)@imbajin Is it only for cleaning the license header in properties files in user configuration files here? I found that some other user configuration files have license headers.
@VGalaxies The current judgment points are:
Also, do properties files in the
conf-raft*
directory need to have their license headers cleaned?
So these places seem to fit the 1st & 3rd points and can preserve license headers.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need