apache / incubator-hugegraph

A graph database that supports more than 100+ billion data, high performance and scalability (Include OLTP Engine & REST-API & Backends)
https://hugegraph.apache.org
Apache License 2.0
2.58k stars 512 forks source link

[Bug(pd-store)] hstore backend api tests failure #2461

Open VGalaxies opened 4 months ago

VGalaxies commented 4 months ago

subtask of #2265, see https://github.com/apache/incubator-hugegraph/actions/runs/7955139768/job/21713633913?pr=2450

dosubot[bot] commented 4 months ago

🤖

Based on the information you've provided, it appears that the testBackendStoreInfo test is failing at the line Assert.assertFalse(backendStoreInfo.checkVersion());. This assertion is checking if the version of the driver is less than the version of the store, which is expected to be false. If this assertion is failing, it means that the checkVersion() method is returning true when it should return false.

To resolve this issue, you need to investigate the implementation of the checkVersion() method in the BackendStoreInfo class. The method should return false if the driver version is less than the store version.

Unfortunately, without the implementation of the BackendStoreInfo class and the checkVersion() method, I can't provide a more specific solution. Could you provide more context or check the checkVersion() method in the BackendStoreInfo class?

Regarding the versions being used in the test, the current version of the driver being used in the test is "1.10" and the store version is "1.11". This is set up in the test case itself.

As for known issues or bugs related to the checkVersion() method in the BackendStoreInfo class, based on the provided context, there are no known issues or bugs. However, without more context or access to the actual implementation of the checkVersion() method, it's impossible to definitively say there are no issues or bugs.

Lastly, without more information, I can't determine if there have been any recent changes in the BackendStoreInfo class or its dependencies that could have caused the test to fail. If you could provide more details or context, it would be helpful in diagnosing the issue.

For more information, you can refer to the BackendStoreInfoTest.java file in the repository.

Sources

#### About Dosu This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.
VGalaxies commented 4 months ago

@sheli00 could follow up on this issue~

sheli00 commented 4 months ago

@sheli00 could follow up on this issue~

I will keep on following.

VGalaxies commented 4 months ago

After inspection, only the hstore API test testMetricsBackend(org.apache.hugegraph.api.MetricsApiTest) has not passed. The reason is that the hstore backend has not set up the corresponding metrics. Considering that the PD metrics are currently unavailable:

  1. The PdMetricsAPI fetches metrics information from the PD meta store, which depends on the server periodically reporting metrics to PD (not yet adapted https://github.com/hugegraph/server/tree/master/hugegraph-api/src/main/java/org/apache/hugegraph/metrics).
  2. It seems that PDMetrics is not connected to the PD metrics API.

Therefore, a temporary solution is to directly query the PD gRPC interface in the session to check the number of stores, bypassing the PD metrics API for now.

VGalaxies commented 4 months ago

@sheli00 can participate in the subsequent adaptation of PD (hstore) metrics~