fix(server): Filter dynamice path(PUT/GET/DELETE) with params cause OOM

apache / incubator-hugegraph

A graph database that supports more than 100+ billion data, high performance and scalability (Include OLTP Engine & REST-API & Backends)

https://hugegraph.apache.org

Apache License 2.0

2.58k stars 512 forks source link

fix(server): Filter dynamice path(PUT/GET/DELETE) with params cause OOM #2569

Open JackyYangPassion opened 1 week ago

JackyYangPassion commented 1 week ago

Purpose of the PR

fix #2566

Main Changes

Verifying these changes

[ ] Trivial rework / code cleanup without any test coverage. (No Need)
[ ] Already covered by existing tests, such as (please modify tests here).
[ ] Need tests and can be verified as follows:
- xxx

Does this PR potentially affect the following parts?

[ ] Dependencies (add/update license info & regenerate_dependencies)
[ ] Modify configurations
[ ] The public API
[ ] Other affects (typed here)
[ ] Nope

Documentation Status

[ ] Doc - TODO
[ ] Doc - Done
[ ] Doc - No Need

imbajin commented 1 week ago

@SunnyBoy-WYH could u take a look for it~

SunnyBoy-WYH commented 1 week ago

can we merge the requestContext.getUriInfo()?

URI uri = requestContext.getUriInfo().getRequestUri(); String path = uri.getRawPath(); String method = requestContext.getMethod(); UriInfo uriInfo = requestContext.getUriInfo(); String path = normalizePath(uriInfo.getPath(),method); String metricsName = join(path, method);

SunnyBoy-WYH commented 1 week ago

Let’s not talk about the oom for now. for HISTOGRAM metric，seems path without param will be better.? @JackyYangPassion @imbajin

SunnyBoy-WYH commented 1 week ago

As a consult, Do you have oom system log and ensure the oom due to this map?