search

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
Apache License 2.0
5.88k stars 2.5k forks source link

[new-parser] review drlExpression and drlPrimary in DRLParser.g4 #5807

Open tkobayas opened 7 months ago

tkobayas commented 7 months ago

Parent issue

Issue

https://github.com/apache/incubator-kie-drools/pull/5806#discussion_r1540800031

drlExpression and drlPrimary in DRLParser.g4 are extended rules from JavaParser.g4.

However, constraint related rules should respect DRL6Expressions.g4 so that we can avoid a situation like "This is possible with DRL6Expressions, but not possible with DRLParser". It would also be a good way to find additional unit tests.

tkobayas commented 6 months ago

We have imported DRL6Expressions.g4. This issue could be used to review and clean up unnecessary rules in DRLParser.g4.

tkobayas commented 6 months ago

Not high priority