search

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
Apache License 2.0
5.88k stars 2.5k forks source link

[incubator-kie-drools-5808] [new-parser] Combining DRLParser.g4 and DRL6Expressions.g4 #5845

Closed tkobayas closed 7 months ago

tkobayas commented 7 months ago

Issue:

I raised this PR on top of @yurloc 's effort to import DRL6Expressions.g4, thanks! Now we removed the duplication around constraint expression parser rules. This PR doesn't yet implement Visitor pattern to DRL6Expressions.g4. It can be done some time later.

Before PR in drools-model-codegen

[ERROR] Tests run: 2434, Failures: 140, Errors: 0, Skipped: 9

After PR in drools-model-codegen

[ERROR] Tests run: 2434, Failures: 97, Errors: 0, Skipped: 9
How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request and downstream checks - Push a new commit to the PR. An empty commit would be enough. - for a full downstream build - for github actions job: add the label `run_fdb` - for Jenkins PR check only - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button.
tkobayas commented 7 months ago

@yurloc @mariofusco @gitgabrio Please review, thanks!

tkobayas commented 7 months ago

@yurloc if this PR introduces regressions in drools-traits tests, let me know. I'll investigate (but it might be a separated PR)

yurloc commented 7 months ago

Overall fixing progress: There were 224 failed tests.