search

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
Apache License 2.0
5.88k stars 2.5k forks source link

[incubator-kie-drools-5784] Review DRLParser.g4 and DRL6Expressions.g… #5875

Closed tkobayas closed 6 months ago

tkobayas commented 6 months ago

…4 to replace IDENTIFIER with drlIdentifier

Issue:

Before PR in drools-model-codegen

[ERROR] Tests run: 2434, Failures: 74, Errors: 0, Skipped: 9

After PR in drools-model-codegen

[ERROR] Tests run: 2434, Failures: 72, Errors: 0, Skipped: 9

The main purpose is to hardening backward compatibility with the new test DRLParserIdentifierTest.

tkobayas commented 6 months ago

I have mostly changed from IDENTIFIER to drlIdentifier. But only operator_key and neg_operator_key in DRL6Expressions.g4 were remaining, because it seems to have a deeper problem, so I split it to https://github.com/apache/incubator-kie-drools/issues/5874

tkobayas commented 6 months ago

@yurloc @mariofusco @gitgabrio Please review, thanks!