apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
5.85k stars 2.49k forks source link

[kie-issues#1169] Add license headers to files #5902

Closed baldimir closed 4 months ago

baldimir commented 4 months ago

Resolves: https://github.com/apache/incubator-kie-issues/issues/1169

kie-ci3 commented 4 months ago

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u https://github.com/apache/incubator-kie-drools/pull/5902 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5902/1/display/redirect

Test results:

Those are the test failures:

org.drools.drlonyaml.cli.tests.ConversionsUsingCliTest.testDrl2Yaml [the converted Yaml matches the expected content)] expected:<"[##LicensedtotheApacheSoftwareFoundation(ASF)underone#ormorecontributorlicenseagreements.SeetheNOTICEfile#distributedwiththisworkforadditionalinformation#regardingcopyrightownership.TheASFlicensesthisfile#toyouundertheApacheLicense,Version2.0(the#"License");youmaynotusethisfileexceptincompliance#withtheLicense.YoumayobtainacopyoftheLicenseat##http://www.apache.org/licenses/LICENSE-2.0##Unlessrequiredbyapplicablelaworagreedtoinwriting,#softwaredistributedundertheLicenseisdistributedonan#"ASIS"BASIS,WITHOUTWARRANTIESORCONDITIONSOFANY#KIND,eitherexpressorimplied.SeetheLicenseforthe#specificlanguagegoverningpermissionsandlimitations#undertheLicense.#]---name:mypkgdialect...> but was:<"[]---name:mypkgdialect...>
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_2_to_1_3 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_7_to_1_8 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_0_to_1_1 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_5_to_1_6 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_3_to_1_4 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.unmarshalRULE The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_1_to_1_2 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_6_to_1_7 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.migrateIfNecessary_1_4_to_1_5 The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.backend.util.ScenarioSimulationXMLPersistenceTest.unmarshalDMN The processing instruction target matching "[xX][mM][lL]" is not allowed.
org.drools.scenariosimulation.integrationtest.ScenarioTest.initializationError Issue on parsing file: /home/jenkins/jenkins-agent/workspace/llrequest_jobs_drools-pr_PR-5902/kogito-pipelines/bc/apache_incubator-kie-drools/drools-scenario-simulation/drools-scenario-simulation-integrationtest/target/test-classes/importedDMN/TrafficViolationTest.scesim
org.drools.mvel.compiler.lang.ErrorsParserTest.testExpanderErrorsAfterExpansion expected:<[6]> but was:<[8]>
org.drools.mvel.integrationtests.DslTest.testMultiLineTemplates[KieBase type=CLOUD_IDENTITY] expected:<"[when Car(color=="Red") then doSomething();]"> but was:<"[Add 2 percent
to all Red cars]">
org.drools.mvel.integrationtests.DslTest.testMultiLineTemplates[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] expected:<"[when Car(color=="Red") then doSomething();]"> but was:<"[Add 2 percent
to all Red cars]">
it.pkg.ScenarioJunitActivatorTest.initializationError Issue on parsing file: /home/jenkins/jenkins-agent/workspace/llrequest_jobs_drools-pr_PR-5902/kogito-pipelines/bc/apache_incubator-kie-drools/kie-archetypes/kie-drools-dmn-archetype/target/test-classes/projects/integrationtestDefaults/project/basic/target/test-classes/TrafficViolationTest.scesim
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.qNameSerialization [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0001 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0002 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0003 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0004 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0005_decision_list [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.helloWorldSemanticNamespaceWithExtensionsOtherNsLocation [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.ch11 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.dish [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.test0004_ns_other_location [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.dummyRelation [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.helloWorldSemanticNamespaceWithExtensions [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.semanticNamespace [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.hardcoded_java_max_call [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_1.UnmarshalMarshalTest.helloWorldSemanticNamespace [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.font_size_shared_style [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12_dmndiDiagramElementExtensionWithContent [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.dmnlabel_text [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12_DecisionService20180911v12 [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12Simple [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12_DiamondWithColors [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12_dmndiDiagramElementExtension [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.hardcoded_java_max_call [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12Ch11example [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12DecisionList [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_2.UnmarshalMarshalTest.v12_ImportName [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13RecommendedLoanProduct [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13Ch11exampleAsFromOMG [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13FunctionItem [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13Financial [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13Simple [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13DecisionList [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13Group [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13LoanInfo [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_3.UnmarshalMarshalTest.v13Dmnedge [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Simple [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Quantified [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14For [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14LoanInfo [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Conditional [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Ch11exampleAsFromOMG [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Financial [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14RecommendedLoanProduct [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_4.UnmarshalMarshalTest.v14Filter [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_loan_info The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_ch11example_asFromOMG The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_recommended_loan_product The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_quantified The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_filter The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_financial The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_for The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_simple The schema is invalid
org.kie.dmn.backend.marshalling.v1_5.UnmarshalMarshalTest.testv15_conditional The schema is invalid
org.kie.dmn.trisotech.backend.marshalling.v1_3.xstream.UnmarshalMarshalTest.v13Conditional [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.trisotech.backend.marshalling.v1_3.xstream.UnmarshalMarshalTest.v13Iterator [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
org.kie.dmn.trisotech.backend.marshalling.v1_3.xstream.UnmarshalMarshalTest.v13Filter [XML are NOT similar: Expected child nodelist length '2' but was '1' - comparing at / to at /]
Expecting value to be false but was true
LightGuard commented 4 months ago

Not exactly the same error I was receiving, but it does look like it is related to the XML parsing.

LightGuard commented 4 months ago

The scesim files look like they're going to be a problem too. I believe the XML declaration is supposed to be the the first thing in the file. Having a comment first seemed problematic while I was changing things in runtimes as well.

baldimir commented 4 months ago

I pushed some fixes. Moving this to Ready for review as the tests pass for me, when I run it locally.