[new-parser] Support ISO 8601 format for duration attribute's value - Githubissues

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.

http://www.drools.org

5.85k stars 2.49k forks source link

[new-parser] Support ISO 8601 format for duration attribute's value #5938

Open yurloc opened 4 months ago

yurloc commented 4 months ago

Parent issue

5678

Failing tests

None. Discovered accidentally.

Notes

Add a new test to org.drools.drl.parser.antlr4.MiscDRLParserTest. Related to #5937. Two options:

Develop a lexer rule that defines a token for ISO 8601 durations or reuse https://github.com/antlr/grammars-v4/tree/master/iso8601 (if 0BSD is compatible with ASL 2.0). Use the token in the attribute rule in DRLParser.g4.
Make the attribute rule less specialized and use the chunk rule for the duration attribute's value. This is the behavior of the old parser's intOrChunkAttribute method.

Rule code snippet

rule R
  duration ("P1DT1M")
when
end

Error output

N/A.

tkobayas commented 4 months ago

/take

tkobayas commented 4 months ago

This is a part of https://github.com/apache/incubator-kie-drools/issues/5972