apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
5.85k stars 2.49k forks source link

[incubator-kie-drools-5924] [new-parser] Remove DRLIncompleteCodeTest #5941

Closed tkobayas closed 4 months ago

tkobayas commented 4 months ago

Issue

        DrlParser parser = new DrlParser(LanguageLevelOption.DRL5);
        PackageDescr descr = parser.parse(true, input);

parse(true, means that it's in Editor mode. When Editor mode:

Here "Editor" means Eclipse plugin and web workbench, which had already retired in Drools 8.

The next DRL Editor aims at LSP based ones. So I think there is no reason to implement the Editor mode and pass DRLIncompleteCodeTest. Implementing the Editor mode may not be a large effort, but it would pollute DRLVisitorImpl code.

tkobayas commented 4 months ago

@yurloc @mariofusco @gitgabrio Please review, thanks!

yurloc commented 4 months ago

@tkobayas Please consider also removing/ignoring

which use the parser in editor mode.

tkobayas commented 4 months ago

I'd rather completely remove this test instead of simply flag it as ignored. I don't see how it could be useful in future.

Please consider also removing/ignoring

  • org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError
  • org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError2 which use the parser in editor mode.

@mariofusco @yurloc Thanks, both done.