Closed tkobayas closed 2 weeks ago
@yurloc @mariofusco @gitgabrio Please review, Thanks!
@yurloc Thank you for pointing out that, and sorry for not finding it beforehand. I'll investigate it.
I found that adding ?
to relationalExpression
solves the issue, but I postpone this fix until we will fix some more remaining test failures so that I can see the potential side-effect easily. Also this issue isn't related to any existing tests.
--- a/drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRL6Expressions.g4
+++ b/drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRL6Expressions.g4
@@ -505,7 +505,7 @@ locals [ BaseDescr lsd ]
$relationalExpression::lsd = $result;
}
}
- )*
+ )*?
;
@tkobayas Is this work still pending? If so what is missing?
@mariofusco Thanks. I'll come back to work on this. This is relatively low priority. and should not block https://github.com/apache/incubator-kie-drools/pull/5989
This is not an immediate problem. Closing.
…tor_key and neg_operator_key in DRL6Expressions.g4
Issue:
Thanks to https://github.com/apache/incubator-kie-drools/commit/d57c5da8b785bca3f35e6a32297bc3ba7a69843b , this is no longer an issue, so I adapted
drlIdentifier
and enabled the tests.