apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
5.85k stars 2.49k forks source link

[incubator-kie-drools-5818] [new-parser] Parsing fails if a Java keyw… #5958

Closed tkobayas closed 4 months ago

tkobayas commented 4 months ago

…ord appears in a qualified name

Issue

Also

tkobayas commented 4 months ago

I have to request a change. I don't have the time to investigate this fully but there is a problem with the new keyword. It might need a special treatment because at this state the PR breaks org.drools.mvel.integrationtests.JittingTest#testBigDecimalConstructorCoercion:

Thanks @yurloc ! I excluded new from drlIdentifier. We may be able to solve the issue by modifying primary rule etc., but it would complicate the difference between the old and new parser, so it would make the future investigation harder. I think at this stage, it' better to go for a simple fix to pass existing unit tests and, list any backward compatibility issues in https://github.com/apache/incubator-kie-drools/issues/5962 , so we can evaluate them in the next round.

yurloc commented 4 months ago

@mariofusco @gitgabrio please review and merge, thanks!