search

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
Apache License 2.0
5.88k stars 2.5k forks source link

Enhanced testSalienceIntegerAndLoadOrder for better memory management and type safety #6042

Closed Rashmesh closed 3 months ago

Rashmesh commented 3 months ago

NOTE!: Double-check the target branch for this PR.

Ports: If a forward-port or a backport is needed, paste the forward port PR here
NA

Issue: (please edit the GitHub Issues link if it exists)
NA

Referenced Pull Requests:
NA

How to replicate CI configuration locally? Performed the following: ```bash git clone https://github.com/kiegroup/github-action-build-chain.git cd github-action-build-chain npm install ``` Create a configuration `build-chain-config.yml`: ```yaml repositories: - name: kiegroup/drools branch: main ``` Run: ```bash node dist/index.js --flow-type pr --config ./build-chain-config.yml ``` Tested it locally also by running the drools-test-coverage
tkobayas commented 3 months ago

Hi @Rashmesh , thank you for the PR.

I see that this PR does:

Both are totally valid and better coding, but I wonder if we will take this kind of PR per test method.

Probably you are aware that many test cases in this project have similar room to improve. It would be great to improve them at once e.g. using a shell script or OpenRewrite (https://docs.openrewrite.org/). If manual intervention is required, hmm, at least PR per test class would be nice? I'm not asking you to do that now. Just thinking out loud...

Any thoughts? > @pibizza @mariofusco

tkobayas commented 3 months ago

One more note: Basically, we file an "issue" with description and put a link to the issue in a PR.

for example) Issue: https://github.com/apache/incubator-kie-drools/issues/6016 PR: https://github.com/apache/incubator-kie-drools/pull/6024