apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
5.85k stars 2.49k forks source link

[incubator-kie-issues#1411] Adapt DMN code to deal with full href definition (namespace#local_part) for local elements. #6050

Closed gitgabrio closed 1 month ago

gitgabrio commented 1 month ago

Fixes https://github.com/apache/incubator-kie-issues/issues/1411

@bncriju

How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request and downstream checks - Push a new commit to the PR. An empty commit would be enough. - for a full downstream build - for github actions job: add the label `run_fdb` - for Jenkins PR check only - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button.
gitgabrio commented 1 month ago

Thank you @gitgabrio . I have just a single comment. Not sure about http://www.montera.com usage. I know currently it is not used by any company, but that may change in future I guess? Maybe more safe would be to use more demo-ish?

* `http://www.mycompany.com`

* `http://www.dmntestcompany.com`

* `http://www.example.com`

Hi @jomarko Those are the names used in the TCK, and I took them as they are. We may consider to replace them in future, but I would prefer to merge this PR now. THanks again!