search

apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
5.85k stars 2.49k forks source link

MetricLogUtils forcibly uses Micrometer when available in classpath #6053

Closed tkobayas closed 1 month ago

tkobayas commented 1 month ago

https://kie.zulipchat.com/#narrow/stream/232677-drools/topic/Spring.20Batch.20Metrics

MetricLogUtils looks for io.micrometer.core.instrument.Tag. If it exists, micrometerAvailable is set to true.

https://github.com/apache/incubator-kie-drools/blob/main/drools-metric/src/main/java/org/drools/metric/util/MetricLogUtils.java#L42-L50

Then, MetricLogUtils automatically uses Micrometer and doesn't print trace logging.

https://github.com/apache/incubator-kie-drools/blob/main/drools-metric/src/main/java/org/drools/metric/util/MetricLogUtils.java#L95-L99

It's not good for users who have Micrometer, but want to review trace logging.

Let's introduce a flag to choose.