apache / incubator-kie-drools

Drools is a rule engine, DMN engine and complex event processing (CEP) engine for Java.
http://www.drools.org
Apache License 2.0
5.88k stars 2.5k forks source link

[NO_ISSUE] Change log level from error to debug inside ImportDMNResolverUtil #6150

Closed gitgabrio closed 6 days ago

gitgabrio commented 1 week ago

Currently, the ImportDMNResolverUtil#resolveImportDMN(Import, Collection<T>, Function<T, QName>) log an error message if a matching imported model can't be found in the given Collection.

Unfortunately, the DMNValidatorImpl#processDMNResourcesAndValidate(DMNMessageManager, List<DMNResource>) (indirectly) invokes it with an empty collection, always leading to misleading "error" message logged.

That message logging has been introduced recently, but the actual behavior did not change, so setting it to "debug" has not any backward/behavior impact.

How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request and downstream checks - Push a new commit to the PR. An empty commit would be enough. - for a full downstream build - for github actions job: add the label `run_fdb` - for Jenkins PR check only - If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on `Build Now` button.
gitgabrio commented 6 days ago

kogito-runtimes failure unrelated

apache_incubator-kie-kogito-runtimes/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java:405 | expected: 2 but was: 1