Support for Bitbucket Data Center on KIE Sandbox

[tiagobento]

As Bitbucket server is reaching EOL exactly one year from now [1], only support for Bitbucket Data Center makes sense.

KIE Sandbox should support integrating with Bitbucket Data Center instances much like it does with github.com, bitbucket.org and GHES.

[1] https://www.atlassian.com/software/bitbucket/enterprise

[jstastny-cz]

There is a free trial for 30 days: https://confluence.atlassian.com/bitbucketserver/get-a-bitbucket-data-center-trial-license-1188400764.html

Regarding the implementation there are significant differences between the Cloud and Data Center:

• the REST API offered by Data Center is probably the Bitbucket Server v1.0(https://community.atlassian.com/t5/Bitbucket-questions/Does-the-rest-api-2-0-exist-for-server/qaq-p/881631), which differs from Bitbucket Cloud v2.0 which is currently supported in KIE Sandbox. This will require a separate client for each version.
• Snippets are just Bitbucket Cloud feature
• App Passwords seem to be Bitbucket Cloud - specific.

It seems that Bitbucket Data Center will need to be handled as a separate git variant, as there are probably no shared parts when it comes to REST API invocation (endpoints differ, auth options differ, feature scopes differ).

• One option would be to introduce distinction between Bitbucket Cloud and Bitbucket DataCenter internally, so that we can plug the right client in when needed, e.g.
  • Instead of currently having

    const createRepositoryCommand: () => Promise<CreateRepositoryResponse> = switchExpression(authProvider?.type, {
    bitbucket: createBitbucketRepository,
    github: createGitHubRepository,
    });

  • we'd have sth as

    const createRepositoryCommand: () => Promise<CreateRepositoryResponse> = switchExpression(authProvider?.type, {
    bitbucket_cloud: createBitbucketCloudRepository,
    bitbucket_data_center: createBitbucketDataCenterRepository,
    github: createGitHubRepository,
    });

  • which would lead to changing things in many places. But thanks to switchExpression there's compile-time check for whether adjusted in all the places.
• Other option could be to try to carry the API version information in GitAuthSession and in the bitbucket/Hooks.tsx decide which request to send based on the authSession contents.
  • This would lead to problems due to feature-parity - e.g. to distinguish whether snippets-related operations should be allowed/visible. Also the actual way of creating and initializing repositories can differ, thus it might not be 1-1 mapping between necessary requests to be invoked cloud vs. data-center.