search

apache / incubator-kie-issues

Apache License 2.0
12 stars 1 forks source link

Flaky Test in `chrome-extension-serverless-workflow-editor` #1196

Open yesamer opened 6 months ago

yesamer commented 6 months ago

In this PR, we discovered a Flaky Test present in chrome-extension-serverless-workflow-editor.

That test points to a yaml file to the main branch, totally ignoring any potential change introduced in the yaml file in a Pull request.

We should find an alternative to manage that file. Most probably the Chrome extension requires a fixed repo to perform a test against it. However, the current logic in place should be avoided.

Check if other tests are using the same approach: as a suggestion, please review all hardcoded https://github.com/apache/incubator-kie-tools/ instances

tiagobento commented 4 months ago

FYI @fantonangeli @handreyrc

fantonangeli commented 4 months ago

@yesamer and @tiagobento I can think 2 solutions:

  1. change these lines, to compare the editorContent against the raw content url. This is faster to achieve but always uses the "previous" version of the yaml in the test.
  2. update the editor content with the local yaml content before comparing. This ensure we are using the last version of the yaml but requires more interaction with the GH workflow page