apache / incubator-kie-issues

Apache License 2.0
12 stars 1 forks source link

Fix `stunner-editors` broken tests and re-enable them on kie-tools #1431

Open thiagoelg opened 1 month ago

thiagoelg commented 1 month ago

On 2024-08-07 some tests stopped working on stunner-editors in kie-tools due to the following (or similar) error:

java.lang.NullPointerException: Cannot invoke "org.kie.workbench.common.stunner.bpmn.client.forms.fields.i18n.StunnerFormsClientFieldsConstants.Data_Inputs()" because "org.kie.workbench.common.stunner.bpmn.client.forms.fields.i18n.StunnerFormsClientFieldsConstants.CONSTANTS" is null

This task aims to fix these tests and re-enable them.

It's worth noting that it was not possible to reproduce these issues locally, as building and running tests worked normally.

List of broken and now disabled tests (from kie-wb-common-stunner/kie-web-common-stunner-sets/kie-web-common-stunner-bpmn/kie-wb-common-stunner-bpmn-client):

jomarko commented 1 month ago

Thank you for reporting the issue. One thing I decided to check is the history of the changes in the stunner-editors package https://github.com/apache/incubator-kie-tools/tree/main/packages/stunner-editors. We can see there are basically no changes for months. The last changed file that somehow could change the build results is the pom.xml, however also that change is ~1month old. That brings me to an idea if the github action environment wasn't changed somehow, I mean maybe some java or maven version is now different on the ubuntu machine we use for build via github action?

yesamer commented 1 month ago

I agree with @jomarko, 3 days ago a new Ubuntu image was released https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20240804.1 for GitHub action, most likely there's some incompatibility with a tool / software version

thiagoelg commented 1 month ago

I believe that ubuntu-latest still points to Ubuntu 22.04 (which also received an update: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240804.1)