apache / incubator-kie-issues

Apache License 2.0
12 stars 1 forks source link

Quarkus Accelerator is not generating the correct set of dependencies #241

Open porcelli opened 1 year ago

porcelli commented 1 year ago

Description

After applying the Quarkus Accelerator, it's not possible to run the resulting project.

There's maven build failure if you run mvn clean quarkus:dev it will fail with different messages depending of the type of models you have.

Acceptance Criteria

After applying the Quarkus Accelerator, the user should be able to run mvn clean quarkus:dev in their local environment without any error and be able to open the DevUI and, at least, have the Swagger UI to interact with the models.

thiagoelg commented 1 year ago

I tested with our sample.dmn file and it seemed to work, is there another example model I could try?

porcelli commented 1 year ago

Sorry @thiagoelg - I'm in the process of investigate deeper it. I'll report it back soon.

Looks like it was a silly mistake from my side; which hopefully will help us towards having a better experience for our users :)

porcelli commented 1 year ago

we should align this with 1.38 dependencies and with the setup that @pefernan got running embedded instead of running all services via containers!

@pefernan mind share you project link here?

pefernan commented 1 year ago

@porcelli this is the project link. Let me give it a look to fix the issue you mentioned before.

tiagobento commented 1 year ago

Ok, so I created a new Sample.dmn on KIE Sandbox and applied our Quarkus Accelerator. I used the Accelerator from here: https://github.com/kiegroup/kie-sandbox-quarkus-accelerator/tree/0.0.0

  1. It doesn't work without Docker, and a bunch of errors are thrown when running mvn quarkus:dev
  2. Even with Docker running, I keep getting errors because the app cannot connect with other stuff. See the logs below.
2023-05-31 18:29:32,370 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-variables-events) [Producer clientId=kafka-producer-kogito-variables-events] Connection to node -1 (localhost/127.0.0.1:9092) could not be established. Broker may not be available.
2023-05-31 18:29:32,370 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-variables-events) [Producer clientId=kafka-producer-kogito-variables-events] Bootstrap broker localhost:9092 (id: -1 rack: null) disconnected
2023-05-31 18:29:38,171 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-usertaskinstances-events) [Producer clientId=kafka-producer-kogito-usertaskinstances-events] Connection to node -1 (localhost/127.0.0.1:9092) could not be established. Broker may not be available.
2023-05-31 18:29:38,172 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-usertaskinstances-events) [Producer clientId=kafka-producer-kogito-usertaskinstances-events] Bootstrap broker localhost:9092 (id: -1 rack: null) disconnected
2023-05-31 18:29:39,445 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-processinstances-events) [Producer clientId=kafka-producer-kogito-processinstances-events] Connection to node -1 (localhost/127.0.0.1:9092) could not be established. Broker may not be available.
2023-05-31 18:29:39,446 WARN  [org.apa.kaf.cli.NetworkClient] (kafka-producer-network-thread | kafka-producer-kogito-processinstances-events) [Producer clientId=kafka-producer-kogito-processinstances-events] Bootstrap broker localhost:9092 (id: -1 rack: null) disconnected

@thiagoelg @pefernan @porcelli

porcelli commented 1 year ago

accelerator should be updated to the recent version of embedded services (available for 1.38).

with embedded it's supposed to work without docker

tiagobento commented 1 year ago

@thiagoelg Is this done? If so, what was the resolution?

thiagoelg commented 1 year ago

Not done. Docker is still required for the full DMN/BPMN experience with the accelerator even with the latest version.

We can split this accelerator into two, just like we did with BAMOE, keeping upstream and downstream closer.

tiagobento commented 1 year ago

@baldimir @martinweiler Did we manage to remove the Docker dependency? If not, do we have plans to do it?

baldimir commented 1 year ago

I am not sure, I was not part of this issue before.

porcelli commented 1 year ago

this is not solved, the current setup requires postgresql (dev services dependency) that uses container.

to solve this issue, it's required to provide an H2 (or similar) implementation of the persistence mechanism for DevUI purposes.

thiagoelg commented 8 months ago

@porcelli I'm working on adding support for BPMN files on our Dev deployments, but I remember that needing Docker was a deal breaker :/

Is DevServices still needed to run everything? I've managed to run this example with the quarkus.devservices.enabled=false setting and it seemed to work, but maybe this is a not a good example to test things...

Edit: This is a reproducer based on our kogito-blank-app for Dev deployments.