search

apache / incubator-kie-kogito-apps

Kogito Apps - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
60 stars 127 forks source link

kie-issues#527: Fix @kogito-apps/form-details: The embedded monaco-editor doesn't show the proper syntax highlighting #1885

Closed jomarko closed 1 year ago

jomarko commented 1 year ago

Partially closes kiegroup/kie-issues#527

Because the mentioned ticket affects two modules:

This PR fix the runtime-tools-dev-ui-webapp, however runtime-tools-quarkus-extension-deployment still needs to be addressed.

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request checks Please add comment: Jenkins retest this - for a specific pull request check Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests - for quarkus branch checks Run checks against Quarkus current used branch Please add comment: Jenkins run quarkus-branch - for a quarkus branch specific check Run checks against Quarkus current used branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch - for quarkus main checks Run checks against Quarkus main branch Please add comment: Jenkins run quarkus-main - for a specific quarkus main check Run checks against Quarkus main branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main - for quarkus lts checks Run checks against Quarkus lts branch Please add comment: Jenkins run quarkus-lts - for a specific quarkus lts check Run checks against Quarkus lts branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts - for native checks Run native checks Please add comment: Jenkins run native - for a specific native check Run native checks Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native - for native lts checks Run native checks against quarkus lts branch Please add comment: Jenkins run native-lts - for a specific native lts check Run native checks against quarkus lts branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
Quarkus-3 PR check is failing ... what to do ? The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`. The first patch, called `0001_before_sh.patch`, is generated from Openrewrite `.ci/environments/quarkus-3/quarkus3.yml` recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch. No panic, there is an easy way to regenerate it. You just need to comment on the PR: ``` jenkins rewrite quarkus-3 ``` and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated. Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.
pefernan commented 1 year ago

@yesamer wait, because I think this is still on progress :P

jomarko commented 1 year ago

@yesamer yes, @pefernan is correct, this is still draft, work in progress, here is the current state ()

1.) in runtime-tools-dev-ui-webapp we fixed missing colors and icons for html and tsx form editor (so we have a progress, yay!) 2.) in runtime-tools-quarkus-extension-deployment is the situation still the same

About the second point, it is for sure related to copying assets to some path, we do not know proper path, from my work, I do not think all assets can be copied to the same path

My plan is to: 1.) keep runtime-tools-quarkus-extension-deployment in the same broken state as it is currently, but remove duplicated files, do simple exercise, grep -name envelope.js it will return three copies on my machine, I believe only dev-static/webapp/envelope.js is needed 2.) once we minify files copied from runtime-tools-dev-ui-webapp , lets try to find their proper placement for runtime-tools-quarkus-extension-deployment

jomarko commented 1 year ago

@yesamer @pefernan hi, let me share the status

1.) in runtime-tools-dev-ui-webapp we fixed now colors and fonts 2.) in runtime-tools-quarkus-extension-deployment is the situation still the same, I just decreased quite amount of files we copy from runtime-tools-dev-ui-webapp into runtime-tools-quarkus-extension-deployment, however changes in runtime-tools-quarkus-extension-deployment/pom.xml are not final .

About the second point, I tried to summarize our issue on quarkus zulip topic https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/loading.20static.20resources

The code we use in https://github.com/apache/incubator-kie-kogito-apps/blob/main/runtime-tools-quarkus-extension-parent/runtime-tools-quarkus-extension-deployment/src/main/java/org/kie/kogito/runtime/tools/quarkus/extension/deployment/DevConsoleProcessor.java#L58 is deprecated, if you check in IDE and seems quite different from documented BuildStep here https://quarkus.io/guides/writing-extensions#extension-defined-endpoints

What is your suggestion please?

kie-ci3 commented 1 year ago

PR job #8 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/pull-request-config.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/8/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.it.trusty.SpringBootTrustyExplainabilityEnd2EndIT.doTest Container startup failed
org.kie.kogito.index.service.KeycloakOracleIndexingServiceIT.testUnauthorizedUserAccess java.lang.reflect.InvocationTargetException
org.kie.kogito.jitexecutor.bpmn.api.BPMNValidatorResourceTest.validateModel_MultipleValidBPMN2 java.lang.RuntimeException: Failed to start quarkus
kie-ci3 commented 1 year ago

PR job #11 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/11/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.jobs.service.resource.KeycloakJobServiceTest.(?) java.lang.reflect.InvocationTargetException
org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.trusty.ui.KeycloakTrustyUIServiceIT.(?) java.lang.reflect.InvocationTargetException
org.kie.kogito.trusty.ui.StaticContentTest.testIndexHtml java.lang.reflect.InvocationTargetException
org.kie.kogito.trusty.service.common.KeycloakTrustyServiceIT.(?) java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
at java.base/java.lang.Thread.run(Thread.java:829)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372)
at java.base/java.util.Optional.orElseGet(Optional.java:369)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195)
... 11 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*'
at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485)
... 19 more
org.kie.kogito.trusty.service.common.api.DecisionsApiV1IT.testGetExecutionById java.lang.reflect.InvocationTargetException
kie-ci3 commented 1 year ago

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/test/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/1/display/redirect

Test results:

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.jobs.ProcessTimerIT.testTimers 1 expectation failed.
JSON path data.Jobs[0].status doesn't match.
Expected: is "EXECUTED"
Actual: SCHEDULED
org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus
kie-ci3 commented 1 year ago

PR job #12 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/12/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.quarkus.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8083, 39767] should be listening)
PR check / Build projects / org.acme.travels.ApprovalsProcessIT.testApprovalProcess java.lang.reflect.InvocationTargetException
org.acme.travels.ApprovalsRestIT.testStartApprovalUnauthenticated Failed to load ApplicationContext
PR check / Build projects / org.acme.travels.ApprovalsRestIT.testStartApprovalAuthorized Failed to load ApplicationContext
org.kie.kogito.springboot.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8080, 39859] should be listening)
org.acme.travels.ApprovalsProcessTestIT.testApprovalProcess Failed to load ApplicationContext
org.acme.travels.ApprovalsProcessTestIT.testApprovalProcessViaPhases Failed to load ApplicationContext
org.acme.AcmeExchangeResourceIT.unauthorizedTest java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
at java.base/java.lang.Thread.run(Thread.java:829)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372)
at java.base/java.util.Optional.orElseGet(Optional.java:369)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397)
at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195)
... 11 more
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
... 16 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 17 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*'
at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485)
... 19 more
kie-ci3 commented 1 year ago

PR job #13 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/13/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents 1 expectation failed.
JSON path errors doesn't match.
Expected: null
Actual: <[{message=Exception while fetching data (/UserTaskInstanceCommentUpdate) : Index 0 out of bounds for length 0, locations=[{line=1, column=12}], path=[UserTaskInstanceCommentUpdate], extensions={classification=DataFetchingException}}]>
org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus
yesamer commented 1 year ago

@pefernan We can merge it after your approval, failing tests are unrelated.

pefernan commented 1 year ago

@yesamer already approved.. please go ahead!