apache / incubator-kie-kogito-apps

Kogito Apps - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
59 stars 126 forks source link

kie-issues#626: disable Keycloak devservice #1895

Closed jstastny-cz closed 10 months ago

jstastny-cz commented 11 months ago

apache/incubator-kie-issues#626

Disabling Keycloak dev service that is started by default when quarkus-oidc maven dependency is used (https://quarkus.io/guides/dev-services#keycloak).

Given that our tests instead of the Dev service rely on org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource, the dev service started for no use and also caused failures due to strict startTimeout = 60s which was often exceeded. (even after apache/incubator-kie-issues#622 was fixed, because is a different thing)

Also there was version mismatch between the Keycloak image versions being used - that was the main reason to dig into this topic in first place.

kie-ci3 commented 11 months ago

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1895 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1895/1/display/redirect

Test results:

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.jobs.CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus
jstastny-cz commented 11 months ago

Jobs service test failures are known issues.

CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded is not clear, maybe random fail?

Validated the logs by downloading the consoleText output from https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/view/change-requests/job/PR-1895/1/consoleText and executing following command with single value output:

[jstastny@IBM-PF3JSA31:/tmp]$ cat consoleText | sed -n 's#.*Container quay.io\/keycloak\/keycloak\(.*\)is starting.*#\1#p' | uniq
:20.0.2

Which means only the desired keycloak containers are started now.

kie-ci3 commented 11 months ago

PR job #2 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1895 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1895/2/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus
jstastny-cz commented 10 months ago

I am going ahead with the merge to stop wasting build resources by running unused services.