search

apache / incubator-kie-kogito-apps

Kogito Apps - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
60 stars 127 forks source link

[KOGITO-9886] fix IT for data-index and jobs-service with process-definitions events #1913

Closed tiagodolphine closed 11 months ago

tiagodolphine commented 11 months ago

Depends on https://github.com/apache/incubator-kie-kogito-runtimes/pull/3252 https://github.com/apache/incubator-kie-kogito-examples/pull/1821 https://github.com/apache/incubator-kie-kogito-apps/pull/1913

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request checks Please add comment: Jenkins retest this - for a specific pull request check Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests - for quarkus branch checks Run checks against Quarkus current used branch Please add comment: Jenkins run quarkus-branch - for a quarkus branch specific check Run checks against Quarkus current used branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch - for quarkus main checks Run checks against Quarkus main branch Please add comment: Jenkins run quarkus-main - for a specific quarkus main check Run checks against Quarkus main branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main - for quarkus lts checks Run checks against Quarkus lts branch Please add comment: Jenkins run quarkus-lts - for a specific quarkus lts check Run checks against Quarkus lts branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts - for native checks Run native checks Please add comment: Jenkins run native - for a specific native check Run native checks Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native - for native lts checks Run native checks against quarkus lts branch Please add comment: Jenkins run native-lts - for a specific native lts check Run native checks against quarkus lts branch Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
Quarkus-3 PR check is failing ... what to do ? The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`. The first patch, called `0001_before_sh.patch`, is generated from Openrewrite `.ci/environments/quarkus-3/quarkus3.yml` recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch. No panic, there is an easy way to regenerate it. You just need to comment on the PR: ``` jenkins rewrite quarkus-3 ``` and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated. Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.
kie-ci3 commented 11 months ago

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1913 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1913/1/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.inmemory.ProcessDataIndexInMemoryIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.persistence.oracle.OracleStorageServiceIT.testQuery_Equal Error invoking subclass method
kie-ci3 commented 11 months ago

PR job #3 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1913 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1913/3/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.index.infinispan.ProcessDataIndexInfinispanHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.inmemory.ProcessDataIndexInMemoryIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.mongodb.ProcessDataIndexMongoDBHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.oracle.ProcessDataIndexOracleHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
tiagodolphine commented 11 months ago

@nmirasch @wmedvede can you take a look at this one. thanks.

tiagodolphine commented 11 months ago

@tiagodolphine this LGTM, but I have a silly question, as part of this processing of this new event with the process definitions, did you include the necessary addings in the org.kie.kogito.index.service.messaging.KogitoIndexEventConverter class?

Sorry for asking in this PR, maybe you added the changes in another still open PR and have missed it.

The question is because in this class a processing like this is being done:

private boolean isIndexable(Type type) {
    return type == ProcessInstanceDataEvent.class
            || type == UserTaskInstanceDataEvent.class
            || type == KogitoJobCloudEvent.class;
}

etc, so we need to include this new event here.

@wmedvede I did that in the PR to be opened related to all changes in the Data index to consume and index this new type of event. This one is just to keep things working on the runtimes side, but there is no implementation for the data index the idea is to open a follow-up one.