search

apache / incubator-kie-kogito-apps

Kogito Apps - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
58 stars 125 forks source link

kie-issues#746: set timeout for testcontainers after waitingFor invocation #1932

Closed jstastny-cz closed 7 months ago

jstastny-cz commented 7 months ago

Fixes

Another batch of fixes due to misconfiguration of testcontainers coming from the fact that waitingFor method invocation drops previously configured withStartupTimeout value. Need to override after each such call - can't rely on the value set in parent classes.

kie-ci3 commented 7 months ago

PR job #3 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/1932 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1932/3/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.index.service.MongoDomainIndexingServiceIT.testConcurrentProcessInstanceIndex Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.
JSON path data.ProcessInstances[0].state doesn't match.
Expected: is "COMPLETED"
Actual: ACTIVE
within 30 seconds.
pefernan commented 7 months ago

@jstastny-cz should we have this in q3 branch?

jstastny-cz commented 7 months ago

It would be safer - unless we are certain that the version of testcontainers used overthere has changed the implemented behavior.

jstastny-cz commented 7 months ago

I'll try cherry-pick.