search

apache / incubator-kie-kogito-apps

Kogito Apps - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
56 stars 123 forks source link

NO-ISSUE: Revert the removal of repositories in the pom.xml file #2055

Closed rodrigonull closed 1 month ago

rodrigonull commented 1 month ago

Removing the repositories from the pom.xml file caused errors when building kogito-apps:

02:09:29   @ 
02:09:29  [ERROR] The build could not read 1 project -> [Help 1]
02:09:29  [ERROR]   
02:09:29  [ERROR]   The project org.kie.kogito:kogito-apps:999-SNAPSHOT (/home/jenkins/workspace/KIE/kogito/main/other/kogito-apps.weekly-deploy/incubator-kie-kogito-apps/pom.xml) has 1 error
02:09:29  [ERROR]     Non-resolvable parent POM for org.kie.kogito:kogito-apps:999-SNAPSHOT: The following artifacts could not be resolved: org.kie.kogito:kogito-build-parent:pom:999-SNAPSHOT (absent): Could not find artifact org.kie.kogito:kogito-build-parent:pom:999-SNAPSHOT and 'parent.relativePath' points at no local POM @ line 28, column 11 -> [Help 2]

This PR reverts this change back to avoid having this error.

jstastny-cz commented 1 month ago

I'd say don't revert, just add apache.snapshots into repositories to be able to resolve snapshot parents. Reverting brings back the need to specify also Central, because Apache public group is there configured also for releases but had worse performance than central.

jstastny-cz commented 1 month ago

E.g. look here: https://github.com/apache/maven-parent/blob/master/pom.xml#L1001

<repositories>
    <!-- useful to resolve parent pom when it is a SNAPSHOT -->
    <repository>
      <releases>
        <enabled>false</enabled>
      </releases>
      <id>apache.snapshots</id>
      <name>Apache Snapshot Repository</name>
      <url>https://repository.apache.org/snapshots</url>
    </repository>
  </repositories>
kie-ci3 commented 1 month ago

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u https://github.com/apache/incubator-kie-kogito-apps/pull/2055 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2055/1/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService java.util.ConcurrentModificationException
at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)
at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)