search

apache / incubator-kie-kogito-examples

Kogito examples - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
255 stars 380 forks source link

Updating quarkus examples pom.xml files #1988

Closed LightGuard closed 1 month ago

LightGuard commented 2 months ago

Updating the pom files to remove properties which make it confusing for end users. This removes most properties in the pom. The properties removed are only there the change the gav for some dependencies.

jomarko commented 1 month ago

I will review this tomorrow and check the relationship for the exiting PR https://github.com/apache/incubator-kie-kogito-examples/pull/1984. That, probably will be closed, need to check.

mareknovotny commented 1 month ago

hard-coding of version is always not good as that requires manual changes on multiple places later and regularly.

LightGuard commented 1 month ago

I fully understand the argument, and I thought about it. I typically do just that as well. However, when I was doing this one, I looked hard at:

1) how many places do we have this version? Answer: One place. Does it matter if it's in a version tag or a property tag? It is still one place we have to change it. 2) these are examples for people using our software, probably for the first time. They may not be familiar with Maven (I know that sounds odd, but it is true). The easier we can make these examples to follow and use for future starting places for users, the more I think it will work out to our advantage.

LightGuard commented 1 month ago

Why was the PR closed?

fjtirado commented 1 month ago

Why was the PR closed?

A home accident, reopened. Apologies

LightGuard commented 1 month ago

I'll close this one and create a new PR.