search

apache / incubator-kie-kogito-examples

Kogito examples - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
256 stars 383 forks source link

incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules #2014

Closed pefernan closed 1 month ago

pefernan commented 1 month ago

Closes https://github.com/apache/incubator-kie-issues/issues/1483

Ensemble: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3672 https://github.com/apache/incubator-kie-kogito-apps/pull/2102 https://github.com/apache/incubator-kie-kogito-examples/pull/2014

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

WARNING! Please make sure you are opening your PR against main branch!

How to replicate CI configuration locally? Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use [build-chain tool](https://github.com/kiegroup/github-action-build-chain) to handle cross repository builds and be sure that we always use latest version of the code for each repository. [build-chain tool](https://github.com/kiegroup/github-action-build-chain) is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See [local execution](https://github.com/kiegroup/github-action-build-chain#local-execution) details to get more information about it.
How to retest this PR or trigger a specific build: - for pull request checks Please add comment: Jenkins retest this - for a specific pull request check Please add comment: Jenkins (re)run [kogito-examples] tests - for quarkus branch checks Run checks against Quarkus current used branch Please add comment: Jenkins run quarkus-branch - for a quarkus branch specific check Run checks against Quarkus current used branch Please add comment: Jenkins (re)run [kogito-examples] quarkus-branch - for quarkus main checks Run checks against Quarkus main branch Please add comment: Jenkins run quarkus-main - for a specific quarkus main check Run checks against Quarkus main branch Please add comment: Jenkins (re)run [kogito-examples] quarkus-main - for quarkus lts checks Run checks against Quarkus lts branch Please add comment: Jenkins run quarkus-lts - for a specific quarkus lts check Run checks against Quarkus lts branch Please add comment: Jenkins (re)run [kogito-examples] quarkus-lts - for native checks Run native checks Please add comment: Jenkins run native - for a specific native check Run native checks Please add comment: Jenkins (re)run [kogito-examples] native - for native lts checks Run native checks against quarkus lts branch Please add comment: Jenkins run native-lts - for a specific native lts check Run native checks against quarkus lts branch Please add comment: Jenkins (re)run [kogito-examples] native-lts
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
pefernan commented 1 month ago

In this PR I tried addressing the examples that use flyway to consume the new initializer, however a lot of the examples are still using the old images. So I'll leave them as they are for now.

kie-ci3 commented 1 month ago

PR job #4 was: UNSTABLE Possible explanation: This should be test failures

Reproducer build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u https://github.com/apache/incubator-kie-kogito-examples/pull/2014 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2014/4/display/redirect

Test results:

Those are the test failures:

org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards 1 expectation failed.
JSON path title doesn't match.
Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard"
Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Hello - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Operational Dashboard]>
porcelli commented 1 month ago

not a bad idea to align everything with the new kie flyway.

@pefernan could you open an issue for future tracking?

pefernan commented 1 month ago

sure @porcelli, actually I think it would be good doing it.

pefernan commented 1 month ago

@porcelli there we go https://github.com/apache/incubator-kie-issues/issues/1501