apache / incubator-kie-kogito-images

Images for Kogito
http://kogito.kie.org
Apache License 2.0
23 stars 80 forks source link

[KOGITO-9791] build-quarkus-app.sh: properly define versions of org.apache.maven.plugins to avoid downloading old artifacts #1686

Closed rgdoliveira closed 1 year ago

rgdoliveira commented 1 year ago

Many thanks for submitting your Pull Request :heart:!

Please make sure your PR meets the following requirements:

How to retest this PR or trigger a specific build: - (Re)run Jenkins tests Please add comment: Jenkins [test|retest] this - Prod tests Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
kie-ci1 commented 1 year ago

PR job #1059 was: FAILURE Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1059/display/redirect See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1059/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
rgdoliveira commented 1 year ago

Jenkins retest this

kie-ci1 commented 1 year ago

PR job #1060 was: FAILURE Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1060/display/redirect See console log:

Console Logs
-------------------------------------------------------------
[ERROR] Can't merge source into Target. Please rebase PR branch.
-------------------------------------------------------------
Source: git://github.com/rgdoliveira/kogito-images inject_jboss-parent
Target: 1068c324 [main] Update version to 2.0.0-snapshot
-------------------------------------------------------------

[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Validate CeKit Image and Modules descriptors)
Stage "Validate CeKit Image and Modules descriptors" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build & Test Images)
Stage "Build & Test Images" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1060/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
radtriste commented 1 year ago

PR job #1060 was: FAILURE Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1060/display/redirect See console log:

Console Logs

@rgdoliveira you need to rebase ;)

kie-ci1 commented 1 year ago

PR job #1061 was: UNSTABLE Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1061/display/redirect See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-management-console: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-swf-devmode seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1061/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
spolti commented 1 year ago

hi, can we have a jira for this change?

mareknovotny commented 1 year ago

have you already reported the jira @ricardozanini or we need to create a now one?

ricardozanini commented 1 year ago

@mareknovotny @spolti we don't have a JIRA, I think @rgdoliveira identified the issue and pushed the changes based on our conversation.

rgdoliveira commented 1 year ago

@ricardozanini exactly, I created the PR based on our conversation in the channel last week. I didn't create a Jira for it because I was not sure if we would use this approach or not. So in case we agree on doing that, I can create a Jira and attach to this PR. Please, just let me know how we want to proceed.

ricardozanini commented 1 year ago

@radtriste @rgdoliveira if we can afford to test these changes with the operator, I'm all in. So, I believe we need a JIRA/EPIC to address all the critical CVEs we have in the images.

rgdoliveira commented 1 year ago

@ricardozanini I'm not sure how this changes can be tested with the Operator? I will let @radtriste answer if he knows.

Basically the build-quarkus-app.sh script is used to generate the maven repository zip and the quarkus-app zip (which is the serverless-workflow-project sample project) for both the devmode and builder images.

ricardozanini commented 1 year ago

We need to build the images based on this PR and run a few tests with the operator using these images.

rgdoliveira commented 1 year ago

@ricardozanini hmm @radtriste can correct me if I'm wrong, but I think on the community side the devmode and builder images are built in a different way than in productization.

In community they don't use the build-quarkus-app.sh, they actually build the maven repo zip for the images as part of the images build (like a module in the image), which is something we cannot do on prod side because OSBS doesn't allow to connect to maven central, so we have to use the build-quarkus-app.sh to build the images maven repo zip on PNC and inject that zip when building the images on OSBS.

rgdoliveira commented 1 year ago

btw, I did a better check in the generated maven repo and it seems that using the jboss-parent actually doesn't help a lot with some old artifacts included. anyway, I will create a Jira today so we can track this and I will try a different approach to see if I can get better results.

I've created Jira https://issues.redhat.com/browse/KOGITO-9791

kie-ci1 commented 1 year ago

PR job #1063 was: UNSTABLE Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1063/display/redirect See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-swf-devmode seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1063/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
rgdoliveira commented 1 year ago

@ricardozanini @radtriste @desmax74 I've built the devmode and builder images used for OSL 1.30 using a new maven repository.zip that was generated using this PR.

The images are available on docker.io and can be pulled with: $ docker pull rgdoliveira/sonata-swf-devmode-rhel8:1.30.1 $ docker pull rgdoliveira/sonata-swf-builder-rhel8:1.30.1

kie-ci1 commented 1 year ago

PR job #1064 was: UNSTABLE Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1064/display/redirect See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1686 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-swf-devmode seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1064/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
rgdoliveira commented 1 year ago

@radtriste @ricardozanini could you please review? @desmax74 tested the changes with the Operator and it seems fine.

kie-ci1 commented 1 year ago

PR job #1066 was: FAILURE Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1066/display/redirect See console log:

Console Logs [Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-management-console
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1686 completed: FAILURE
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-trusty-ui
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1686 completed: FAILURE
[Pipeline] error
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-task-console
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1066/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
rgdoliveira commented 1 year ago

Jenkins retest this

kie-ci1 commented 1 year ago

PR job #1067 was: ABORTED Possible explanation: Most probably a timeout, please review

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1067/display/redirect See console log:

Console Logs [Pipeline] // stage
[Pipeline] }
Resuming build at Tue Sep 12 19:15:27 UTC 2023 after Jenkins restart
Waiting for reconnection of rhos-d-kie-rhel8-large-osbs-podman-2515 before proceeding with build
Timeout set to expire in 25 min
Ready to run at Tue Sep 12 19:15:28 UTC 2023
Cancelling nested steps due to timeout
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-runtime-jvm: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-runtime-jvm
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-s2i-builder
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1067/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh
kie-ci1 commented 1 year ago

PR job #1068 was: ABORTED Possible explanation: Most probably a timeout, please review

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1068/display/redirect See console log:

Console Logs [Pipeline] // stage
[Pipeline] }
Resuming build at Tue Sep 12 19:15:28 UTC 2023 after Jenkins restart
Waiting for reconnection of rhos-d-kie-rhel8-large-osbs-podman-2529 before proceeding with build
Timeout set to expire in 29 min
Ready to run at Tue Sep 12 19:15:28 UTC 2023
Cancelling nested steps due to timeout
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-runtime-jvm: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-runtime-jvm
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1686 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1686 completed: ABORTED
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch kogito-s2i-builder
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1068/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh