apache / incubator-kie-kogito-images

Images for Kogito
http://kogito.kie.org
Apache License 2.0
23 stars 80 forks source link

Set OpenShift Serverless Logic productized images to version 1.31.0 #1702

Closed bacciotti closed 1 year ago

bacciotti commented 1 year ago

Many thanks for submitting your Pull Request :heart:!

Please make sure your PR meets the following requirements:

How to retest this PR or trigger a specific build: - (Re)run Jenkins tests Please add comment: Jenkins [test|retest] this - Prod tests Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
spolti commented 1 year ago

@rgdoliveira as peer or discussion, this change should be made in the kogito-images, right?

rgdoliveira commented 1 year ago

@rgdoliveira as peer or discussion, this change should be made in the kogito-images, right?

@spolti I think this one is correct to be here, because at some point main will be forked (cut-off) on 1.45.x and this commit will be part of it. And in fact branch 1.45.x is what will be used for building OSL 1.31.

My understanding is that we should apply in kiegroup/kogito-images repository changes related to legacy branches, like 1.13.x.

spolti commented 1 year ago

Thanks. Is this ready to be merged?

rgdoliveira commented 1 year ago

Thanks. Is this ready to be merged?

It is, please merge it.

spolti commented 1 year ago

OK, just wait for @krisv approval, then I'll merge it.

bacciotti commented 1 year ago

@spolti @rgdoliveira updated.

rgdoliveira commented 1 year ago

@spolti now it is ready to be merged :)