search

apache / incubator-kie-kogito-images

Images for Kogito
http://kogito.kie.org
Apache License 2.0
23 stars 79 forks source link

Make kogito-runtime-jvm to build in the same context as kogito-s2i #1721

Open ricardozanini opened 9 months ago

ricardozanini commented 9 months ago

The only problem left is the s2i builder tests that depends on quay.io/kiegroup/kogito-runtime-jvm:latest. Since now every build runs on its on context, we won't have access to this image from the s2i pipeline. The alternatives we have:

  1. Build the kogito-runtime-jvm together with the s2i pipeline.
  2. Share the context between kogito-runtime-jvm and s2i, or make them run in a single pipeline.

The nightly won't have problems since we should push the tags and the runtime runs before s2i.

We can merge this one if only s2i is failing in the tests in the behave depending on the runtime image. Then, we can fix this problem in a follow-up PR.

The quay.io/kiegroup/kogito-runtime-jvm:latest image is in Java 11, that's the reason you see the failures.

Originally posted by @ricardozanini in https://github.com/apache/incubator-kie-kogito-images/issues/1720#issuecomment-1869783833

ricardozanini commented 9 months ago

cc @baldimir @jakubschwan

@jstastny-cz we need to handle this in some level of urgency if we expect to keep supporting the legacy Kogito Operator/RHPAM Operator builders.

I don't think it's critical, though. But it would be nice to have a feature to build images together/share the registry in the same runs.

ricardozanini commented 9 months ago

This commit has all the ignored tests: https://github.com/apache/incubator-kie-kogito-images/pull/1720/commits/852de14654537785c07ba966d74285aa7c1d01f7