Closed thiagoelg closed 7 months ago
Are you going to still use the same architecture (Cekit) when moving those to kie-tools?
No, we are using kie-tools tooling (image-builder [1]) to build the image now. Also, it's not a Java-based image anymore, we figured out it's enough to have Apache httpd serve the static webapp files and provide a way to change environment variables (to set the data index endpoint, for example).
If we're missing something or not meeting a requirement, let us know.
[1] https://github.com/apache/incubator-kie-tools/tree/main/packages/image-builder
PR job #137
was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/137/display/redirect See console log:
@ricardozanini For the temporary copies of kogito-swf-{devmode,builder}
we intend to keep the same build tools, though... and we'll most likely need your assistance :)
@tiagobento count on me
@thiagoelg please rebase, we've removed unused images and this PR might be simpler now :)
@ricardozanini I'm not sure why ShellCheck is failing, do you have any ideas?
Try looking for this openBinaryFile
method. Maybe it was a script used in the modules you're removing.
PR job #143
was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/143/display/redirect See console log:
@ricardozanini Apparently, ShellCheck never worked (or I'm missing something), because Bash didn't work well with globstar. After I enabled it ShellCheck started printing a bunch of warnings and infos regarding the scripts.
I could add a -S error
to the ShellCheck command so it only alerts for Error cases, but I can't fix the warnings and infos as I don't have the proper context of these scripts.
PR job #144
was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/144/display/redirect See console log:
PR job #145
was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/145/display/redirect See console log:
@thiagoelg please remove the globstar, this action has been working on all the other PRs. I'll take a look after you revert it.
@thiagoelg I think I've found the problem, I'll send a PR later to solve this.
Fixed here: https://github.com/apache/incubator-kie-kogito-images/pull/1756
Once I get green, we can merge, rebase here and we should be good to go.
Awesome! Thanks @ricardozanini
PR job #147
was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/147/display/redirect See console log:
PR job #153
was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/153/display/redirect See console log:
The images build are broken, please see: https://github.com/apache/incubator-kie-kogito-runtimes/issues/3473
PR job #154
was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/154/display/redirect See console log:
PR job #155
was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/155/display/redirect See console log:
Failed tests not related, still issues from cekit/infra.
@ricardozanini What is missing for us to be able to merge this?
PR job #159
was: FAILURE
Possible explanation: Pipeline failure or project build failure
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/159/display/redirect See console log:
@ricardozanini What is missing for us to be able to merge this?
You already have my approval review (which I made last week) and a comment saying that the tests are not related. It could have been merged already.
I'm merging since I'm assuming it's alright from your side too.
Closes https://github.com/apache/incubator-kie-issues/issues/963
This PR removes all references to
kogito-task-console
andkogito-management-console
images, as they are being migrated to kie-tools [1]. It also fixes a small bug in the Makefile that prevented themake
command from building all images.[1] https://github.com/apache/incubator-kie-tools/pull/2226