apache / incubator-kie-kogito-images

Images for Kogito
http://kogito.kie.org
Apache License 2.0
23 stars 80 forks source link

Rename quay to docker in image bundles #1768

Closed ricardozanini closed 6 months ago

ricardozanini commented 6 months ago

Many thanks for submitting your Pull Request :heart:!

Please make sure your PR meets the following requirements:

Fixes https://github.com/apache/incubator-kie-issues/issues/1233

@jstastny-cz I haven't changed the versions yet. We need to agree on the versions here. We have a version for the Kogito Platform, for the internal image modules, and finally the actual tag for the images. We can keep 999-SNAPSHOT and handle it in CI. Or we can handle it in a script in this repo. Let me know the approach you prefer.

How to retest this PR or trigger a specific build: - (Re)run Jenkins tests Please add comment: Jenkins [test|retest] this
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
jstastny-cz commented 6 months ago

@ricardozanini I don't follow the problem with versions though - what is the difference between quay and dockerhub regarding our versioning?

ricardozanini commented 6 months ago

@jstastny-cz I think we will fix it in the way we see problems in the CI. But essentially this is related to now using :main tag instead of -nightly:latest.

tiagobento commented 6 months ago

...and :10.0.x for publications made from the 10.0.x branch.

tiagobento commented 6 months ago

So we can't really "hardcode" main there, because that would make the 10.0.x branch inconsistent.

ricardozanini commented 6 months ago

Once we branch, we must run a script to update this info in the repo.

porcelli commented 6 months ago

@ricardozanini are we good to merge this?

ricardozanini commented 6 months ago

@ricardozanini are we good to merge this?

No, I'm working on a script to update the files in the command line.

porcelli commented 6 months ago

@ricardozanini ahh k, thank you for the update!

ricardozanini commented 6 months ago

@tiagobento we already have the script here:

$ python manage-kogito-version.py --bump-to 10.0.x

I'm merging it. As soon as we define how to do the release/branch process we can adjust if necessary

tiagobento commented 6 months ago

@ricardozanini Will this update the kogito maven artifacts to 10.0.999-SNAPSHOT?

ricardozanini commented 6 months ago

Yes, it will fetch this version if available in Nexus.