search

apache / incubator-kie-kogito-operator

Kubernetes Operator for Kogito
Apache License 2.0
45 stars 79 forks source link

incubator-kie-issues#564: replace copyrights headers/comments in kogito-operator #1534

Closed kbowers-ibm closed 9 months ago

kbowers-ibm commented 9 months ago

Closes https://github.com/apache/incubator-kie-issues/issues/564

Many thanks for submitting your Pull Request :heart:!

Please make sure your PR meets the following requirements:

How to retest this PR or trigger a specific build: * Run operator BDD testing Please add comment: /jenkins test * Run RHPAM operator BDD testing Please add comment: /jenkins RHPAM test
How to backport a pull request to a different branch? In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-`, where `` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch). > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another. Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added. If something goes wrong, the author will be notified and at this point a manual backporting is needed. > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
kbowers-ibm commented 9 months ago

I believe the error in question is unavoidable, due to the nature of this pull request. The headers are changing in all files, including the auto generated through make before-pr and make vet, and theKogito Operator PR Checks / Lint (pull_request) is complaining about the changes in the auto-generated files

Change is detected in some files: 
 M client/clientset/versioned/fake/register.go
 M client/clientset/versioned/scheme/register.go
 Did you run 'make vet' before sending the PR?
Error: Process completed with exit code 1.
yesamer commented 9 months ago

I believe the error in question is unavoidable, due to the nature of this pull request. The headers are changing in all files, including the auto generated through make before-pr and make vet, and theKogito Operator PR Checks / Lint (pull_request) is complaining about the changes in the auto-generated files

Change is detected in some files: 
 M client/clientset/versioned/fake/register.go
 M client/clientset/versioned/scheme/register.go
 Did you run 'make vet' before sending the PR?
Error: Process completed with exit code 1.

@kbowers-ibm Therefore, I expect that any future PR will NOT complain about that, because the code doesn't change on those files. And that means, that the old RH header was manually added after the file generation, that's right?

yesamer commented 9 months ago

@LightGuard Can you please review it again? If it's fine for you, I think we can merge it :)

kbowers-ibm commented 9 months ago

Therefore, I expect that any future PR will NOT complain about that, because the code doesn't change on those files.

That is my expectation as well, I'm hoping we're right :D

And that means, that the old RH header was manually added after the file generation, that's right?

The old RH header was automatically added through running make before-pr, and I've changed it so that make before-prgenerates the Apache header in those files now

LightGuard commented 9 months ago

Thanks for the merge, I got about half way done yesterday before life took over.

Sent from Gmail Mobile

On Thu, Nov 23, 2023 at 06:40 Yeser Amer @.***> wrote:

Merged #1534 https://github.com/apache/incubator-kie-kogito-operator/pull/1534 into main.

— Reply to this email directly, view it on GitHub https://github.com/apache/incubator-kie-kogito-operator/pull/1534#event-11047872165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHKE42Y4JL3RZJXPHOMK3YF5G6XAVCNFSM6AAAAAA7M2HXMCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA2DOOBXGIYTMNI . You are receiving this because you were mentioned.Message ID: <apache/incubator-kie-kogito-operator/pull/1534/issue_event/11047872165@ github.com>