apache / incubator-kie-kogito-runtimes

Kogito Runtimes - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
544 stars 209 forks source link

Business Key is missing from default api responses of POST and GET process #1887

Closed StephenOTT closed 2 years ago

StephenOTT commented 2 years ago

Describe the bug

When you create a process instance (such as in swagger ui), the business key is required. But the Key is not returned in the response (but the process' ID is)

When you do a GET on the process ID, the business key is still not returned.

Expected behavior

the business key being a required field would return in the instance generation response and on GET of the process instance.

fjtirado commented 2 years ago

This is being worked out here https://github.com/kiegroup/kogito-runtimes/pull/1868

fjtirado commented 2 years ago

Also, business key should be optional. But if is there, should be returned, now it is not

StephenOTT commented 2 years ago

Okay then ya it is currently mandatory in the current release.

fjtirado commented 2 years ago

@StephenOTT with #1868, business key will be made optional in swagger. Can you create JIRA for including it in the response of GET and instance generation? I agree this is needed but it is a different JIRA and it is better to not mix things

StephenOTT commented 2 years ago

Created https://issues.redhat.com/browse/KOGITO-6569 for business key in responses